refactor(voice): extract reusable Pocket primitives - #2467
Open
johnmatthewtennant wants to merge 1 commit into
Open
refactor(voice): extract reusable Pocket primitives#2467johnmatthewtennant wants to merge 1 commit into
johnmatthewtennant wants to merge 1 commit into
Conversation
johnmatthewtennant
changed the title
johnmatthewtennant
changed the title
johnmatthewtennant
force-pushed
the
jt/buzz-voice-refactor
branch
from
July 27, 2026 23:06
81f9ee8 to
8ac609c
Compare
johnmatthewtennant
changed the title
| @@ -0,0 +1,654 @@ | |||
| //! Pocket TTS engine wrapper around sherpa-onnx's `OfflineTts`. | |||
Contributor
Author
There was a problem hiding this comment.
🤖 pocket.rs is a code relocation, not a whole-file rename. The exact 166-line implementation from the Desktop file is copied here byte-for-byte; the old Desktop path is replaced with a four-line compatibility re-export.
To verify:
diff -u \
<(git show 43361508c3de49a58672ebb4a1232a05c2e16e35:desktop/src-tauri/src/huddle/pocket.rs) \
<(git show b6daac775a33eaad35fa83114e1c69402bcb3e25:crates/buzz-voice/src/pocket.rs)
echo "exit=$?"Observed output:
exit=0
The empty diff proves the implementation is unchanged. pocket_april.rs and pocket_models.rs are separate whole-file 100% renames.
This was referenced Jul 27, 2026
johnmatthewtennant
force-pushed
the
jt/buzz-voice-refactor
branch
from
July 28, 2026 00:28
8ac609c to
c9dfe50
Compare
johnmatthewtennant
changed the title
johnmatthewtennant
force-pushed
the
jt/buzz-voice-refactor
branch
2 times, most recently
from
July 28, 2026 14:30
a3c16e7 to
0f97b7e
Compare
Signed-off-by: John Tennant <[email protected]>
johnmatthewtennant
force-pushed
the
jt/buzz-voice-refactor
branch
from
July 28, 2026 19:16
0f97b7e to
b6daac7
Compare
johnmatthewtennant
changed the title
johnmatthewtennant
changed the base branch from
main
to
jtennant/pocket-tts-2026-04
July 28, 2026 19:18
Contributor
Author
|
🤖 Fresh CI bookkeeping for exact slim head
No readiness or merge action was taken; the PR remains OPEN+DRAFT. |
johnmatthewtennant
marked this pull request as ready for review
July 28, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Pocket TTS lived inside the Desktop crate and could not be reused by other Buzz clients.
Summary
This relocates the existing implementation into
crates/buzz-voicewithout changing its behavior:desktop/src-tauri/src/huddle/pocket.rscrates/buzz-voice/src/pocket.rsdesktop/src-tauri/src/huddle/pocket_april.rscrates/buzz-voice/src/pocket_april.rsdesktop/src-tauri/src/huddle/pocket_models.rscrates/buzz-voice/src/pocket_models.rsThe remaining changes add the crate facade, manifests, lockfiles, workspace wiring, and test registration. Mobile linking, packaging, callback APIs, patched dependencies, native libraries, and models are not part of this PR.
Excluding generated lockfiles, logical line accounting pairs relocated source with its destination so Git's copy/rename detection does not hide it:
Lines are counted as unchanged destination LOC for relocations and added/removed lines for the remaining handwritten changes.
Testing
buzz-voicetests, full CI, Docker builds, and DCO passed.Reviewer-reproducible examples
Verify the relocation:
Run the moved tests:
cargo test --locked -p buzz-voice --all-targets